claude_code/procedural-3d-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Output warning to stderr if an extension is not supported (#756)

Browse source
This commit is contained in:
Jérôme Leclercq 2020-08-27 19:36:24 +02:00 • committed by GitHub
parent d5be770f55
commit 3298455373
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
base/VulkanDevice.cpp
View file

@ -9,6 +9,7 @@
*/ */
#include <VulkanDevice.h> #include <VulkanDevice.h>
#include <unordered_set>
namespace vks namespace vks
{ {
@ -272,6 +273,12 @@ namespace vks
if (deviceExtensions.size() > 0) if (deviceExtensions.size() > 0)
{ {
for (const char* ext : deviceExtensions)
{
if (!extensionSupported(ext))
std::cerr << ext << " device extension support seems to be missing" << std::endl;
}
deviceCreateInfo.enabledExtensionCount = (uint32_t)deviceExtensions.size(); deviceCreateInfo.enabledExtensionCount = (uint32_t)deviceExtensions.size();
deviceCreateInfo.ppEnabledExtensionNames = deviceExtensions.data(); deviceCreateInfo.ppEnabledExtensionNames = deviceExtensions.data();
} }

17
base/vulkanexamplebase.cpp
View file

@ -7,6 +7,7 @@
*/ */
#include "vulkanexamplebase.h" #include "vulkanexamplebase.h"
#include <unordered_set>
std::vector<const char*> VulkanExampleBase::args; std::vector<const char*> VulkanExampleBase::args;
@ -44,8 +45,24 @@ VkResult VulkanExampleBase::createInstance(bool enableValidation)
instanceExtensions.push_back(VK_MVK_MACOS_SURFACE_EXTENSION_NAME); instanceExtensions.push_back(VK_MVK_MACOS_SURFACE_EXTENSION_NAME);
#endif #endif
std::uint32_t extCount = 0;
vkEnumerateInstanceExtensionProperties(nullptr, &extCount, nullptr);
std::unordered_set<std::string> supportedExtensions;
if (extCount > 0)
{
std::vector<VkExtensionProperties> instanceExtensions(extCount);
vkEnumerateInstanceExtensionProperties(nullptr, &extCount, instanceExtensions.data());
for (const auto &ext : instanceExtensions)
supportedExtensions.emplace(ext.extensionName);
}
if (enabledInstanceExtensions.size() > 0) { if (enabledInstanceExtensions.size() > 0) {
for (auto enabledExtension : enabledInstanceExtensions) { for (auto enabledExtension : enabledInstanceExtensions) {
if (supportedExtensions.find(enabledExtension) == supportedExtensions.end())
std::cerr << enabledExtension << " instance extension support seems to be missing" << std::endl;
instanceExtensions.push_back(enabledExtension); instanceExtensions.push_back(enabledExtension);
} }
} }