diff --git a/base/VulkanTextOverlay.hpp b/base/VulkanTextOverlay.hpp index 3832fdcd..7ed6ae96 100644 --- a/base/VulkanTextOverlay.hpp +++ b/base/VulkanTextOverlay.hpp @@ -665,7 +665,7 @@ public: renderPassBeginInfo.clearValueCount = 0; renderPassBeginInfo.pClearValues = nullptr; - for (int32_t i = 0; i < cmdBuffers.size(); ++i) + for (size_t i = 0; i < cmdBuffers.size(); ++i) { renderPassBeginInfo.framebuffer = *frameBuffers[i]; diff --git a/base/vulkanexamplebase.cpp b/base/vulkanexamplebase.cpp index d79c5633..fcd7f3c8 100644 --- a/base/vulkanexamplebase.cpp +++ b/base/vulkanexamplebase.cpp @@ -545,10 +545,7 @@ void VulkanExampleBase::updateTextOverlay() textOverlay->endTextUpdate(); } -void VulkanExampleBase::getOverlayText(VulkanTextOverlay *textOverlay) -{ - // Can be overriden in derived class -} +void VulkanExampleBase::getOverlayText(VulkanTextOverlay*) {} void VulkanExampleBase::prepareFrame() { @@ -1864,20 +1861,11 @@ void VulkanExampleBase::handleEvent(const xcb_generic_event_t *event) } #endif -void VulkanExampleBase::viewChanged() -{ - // Can be overrdiden in derived class -} +void VulkanExampleBase::viewChanged() {} -void VulkanExampleBase::keyPressed(uint32_t keyCode) -{ - // Can be overriden in derived class -} +void VulkanExampleBase::keyPressed(uint32_t) {} -void VulkanExampleBase::buildCommandBuffers() -{ - // Can be overriden in derived class -} +void VulkanExampleBase::buildCommandBuffers() {} void VulkanExampleBase::createCommandPool() { diff --git a/base/vulkanexamplebase.h b/base/vulkanexamplebase.h index 23b58cb6..ddafdaad 100644 --- a/base/vulkanexamplebase.h +++ b/base/vulkanexamplebase.h @@ -313,8 +313,8 @@ public: // Containing view dependant matrices virtual void viewChanged(); // Called if a key is pressed - // Can be overriden in derived class to do custom key handling - virtual void keyPressed(uint32_t keyCode); + /** @brief (Virtual) Called after a key was pressed, can be used to do custom key handling */ + virtual void keyPressed(uint32_t); // Called when the window has been resized // Can be overriden in derived class to recreate or rebuild resources attached to the frame buffer / swapchain virtual void windowResized(); @@ -334,7 +334,7 @@ public: // Can be overriden in derived class to setup a custom render pass (e.g. for MSAA) virtual void setupRenderPass(); - /** @brief (Virtual) called after the physical device features have been read, used to set features to enable on the device */ + /** @brief (Virtual) Called after the physical device features have been read, can be used to set features to enable on the device */ virtual void getEnabledFeatures(); // Connect and prepare the swap chain @@ -371,9 +371,8 @@ public: void updateTextOverlay(); - // Called when the text overlay is updating - // Can be overriden in derived class to add custom text to the overlay - virtual void getOverlayText(VulkanTextOverlay * textOverlay); + /** @brief (Virtual) Called when the text overlay is updating, can be used to add custom text to the overlay */ + virtual void getOverlayText(VulkanTextOverlay*); // Prepare the frame for workload submission // - Acquires the next image from the swap chain