From 33cb5720580710be4c979f6301645c3a86641451 Mon Sep 17 00:00:00 2001 From: Christian Forfang Date: Sun, 5 Sep 2021 12:17:12 +0200 Subject: [PATCH] Minor fix to access mask - Given newLayout = LAYOUT_SHADER_READ_ONLY_OPTIMAL, upcoming usage is unlikely to be TRANSFER_READ_BIT. - dstAccessMask = FRAGMENT_SHADER makes more sense --- base/VulkanglTFModel.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/base/VulkanglTFModel.cpp b/base/VulkanglTFModel.cpp index ced85b9a..a23d23a2 100644 --- a/base/VulkanglTFModel.cpp +++ b/base/VulkanglTFModel.cpp @@ -267,7 +267,7 @@ void vkglTF::Texture::fromglTfImage(tinygltf::Image &gltfimage, std::string path imageMemoryBarrier.oldLayout = VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL; imageMemoryBarrier.newLayout = VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL; imageMemoryBarrier.srcAccessMask = VK_ACCESS_TRANSFER_WRITE_BIT; - imageMemoryBarrier.dstAccessMask = VK_ACCESS_TRANSFER_READ_BIT; + imageMemoryBarrier.dstAccessMask = VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT; imageMemoryBarrier.image = image; imageMemoryBarrier.subresourceRange = subresourceRange; vkCmdPipelineBarrier(blitCmd, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT, 0, 0, nullptr, 0, nullptr, 1, &imageMemoryBarrier); @@ -1577,4 +1577,4 @@ void vkglTF::Model::prepareNodeDescriptor(vkglTF::Node* node, VkDescriptorSetLay for (auto& child : node->children) { prepareNodeDescriptor(child, descriptorSetLayout); } -} \ No newline at end of file +}