From 8b521e2cd9dd1007bb746ad88abc0de31a371457 Mon Sep 17 00:00:00 2001 From: Hanif Ariffin Date: Sat, 22 Aug 2020 03:21:12 -0400 Subject: [PATCH] Don't perform unecessary copy (#727) --- base/VulkanTools.cpp | 4 ++-- base/VulkanTools.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/base/VulkanTools.cpp b/base/VulkanTools.cpp index 7dd51621..297cbb81 100644 --- a/base/VulkanTools.cpp +++ b/base/VulkanTools.cpp @@ -288,7 +288,7 @@ namespace vks 1, &imageMemoryBarrier); } - void exitFatal(std::string message, int32_t exitCode) + void exitFatal(const std::string& message, int32_t exitCode) { #if defined(_WIN32) if (!errorModeSilent) { @@ -304,7 +304,7 @@ namespace vks #endif } - void exitFatal(std::string message, VkResult resultCode) + void exitFatal(const std::string& message, VkResult resultCode) { exitFatal(message, (int32_t)resultCode); } diff --git a/base/VulkanTools.h b/base/VulkanTools.h index 0d8b296c..a5f043c9 100644 --- a/base/VulkanTools.h +++ b/base/VulkanTools.h @@ -113,8 +113,8 @@ namespace vks VkImageSubresourceRange subresourceRange); // Display error message and exit on fatal error - void exitFatal(std::string message, int32_t exitCode); - void exitFatal(std::string message, VkResult resultCode); + void exitFatal(const std::string& message, int32_t exitCode); + void exitFatal(const std::string& message, VkResult resultCode); // Load a SPIR-V shader (binary) #if defined(__ANDROID__)