From a53721f0dc83acd74a444ad45d410d04600feb89 Mon Sep 17 00:00:00 2001 From: Jakub Kuderski Date: Mon, 14 Dec 2020 16:40:56 -0500 Subject: [PATCH] [NFC] Fix clang warnings Resolves the following clang-10 compiler warnings: ``` $ ninja [65/177] Building CXX object examples/CMakeFiles/oit.dir/oit/oit.cpp.o ../examples/oit/oit.cpp:501:7: warning: 'buildCommandBuffers' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void buildCommandBuffers() ^ ../base/vulkanexamplebase.h:351:15: note: overridden virtual function is here virtual void buildCommandBuffers(); ^ 1 warning generated. [78/177] Building CXX object examples/CMakeFiles/inlineuniformblocks.dir/inlineuniformblocks/inlineuniformblocks.cpp.o ../examples/inlineuniformblocks/inlineuniformblocks.cpp:19:27: warning: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Wimplicit-int-float-conversion] return ((float)rand() / (RAND_MAX)); ~ ^~~~~~~~ /usr/include/stdlib.h:86:18: note: expanded from macro 'RAND_MAX' ^~~~~~~~~~ 1 warning generated. [84/177] Building CXX object examples/CMakeFiles/pushconstants.dir/pushconstants/pushconstants.cpp.o ../examples/pushconstants/pushconstants.cpp:24:28: warning: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Wimplicit-int-float-conversion] return ((float) rand() / (RAND_MAX)); ~ ^~~~~~~~ /usr/include/stdlib.h:86:18: note: expanded from macro 'RAND_MAX' ^~~~~~~~~~ ``` --- examples/inlineuniformblocks/inlineuniformblocks.cpp | 4 ++-- examples/oit/oit.cpp | 4 ++-- examples/pushconstants/pushconstants.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/inlineuniformblocks/inlineuniformblocks.cpp b/examples/inlineuniformblocks/inlineuniformblocks.cpp index 9fb0f92e..e67b5337 100644 --- a/examples/inlineuniformblocks/inlineuniformblocks.cpp +++ b/examples/inlineuniformblocks/inlineuniformblocks.cpp @@ -16,7 +16,7 @@ #define ENABLE_VALIDATION false float rnd() { - return ((float)rand() / (RAND_MAX)); + return static_cast(rand()) / static_cast(RAND_MAX); } class VulkanExample : public VulkanExampleBase @@ -392,4 +392,4 @@ public: }; -VULKAN_EXAMPLE_MAIN() \ No newline at end of file +VULKAN_EXAMPLE_MAIN() diff --git a/examples/oit/oit.cpp b/examples/oit/oit.cpp index 98641deb..c67b0a83 100644 --- a/examples/oit/oit.cpp +++ b/examples/oit/oit.cpp @@ -498,7 +498,7 @@ private: vkUpdateDescriptorSets(device, writeDescriptorSets.size(), writeDescriptorSets.data(), 0, NULL); } - void buildCommandBuffers() + void buildCommandBuffers() override { if (resized) return; @@ -639,4 +639,4 @@ private: VkDeviceSize objectUniformBufferSize; }; -VULKAN_EXAMPLE_MAIN() \ No newline at end of file +VULKAN_EXAMPLE_MAIN() diff --git a/examples/pushconstants/pushconstants.cpp b/examples/pushconstants/pushconstants.cpp index 5e34109b..8e544736 100644 --- a/examples/pushconstants/pushconstants.cpp +++ b/examples/pushconstants/pushconstants.cpp @@ -21,7 +21,7 @@ float rnd() { - return ((float) rand() / (RAND_MAX)); + return static_cast(rand()) / static_cast(RAND_MAX); } class VulkanExample : public VulkanExampleBase @@ -293,4 +293,4 @@ public: } }; -VULKAN_EXAMPLE_MAIN() \ No newline at end of file +VULKAN_EXAMPLE_MAIN()