claude_code/procedural-3d-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #934 from jonnxie/jonnxie

Browse source 
Fixed loadAnimation function memory leak bug.
This commit is contained in:
Sascha Willems 2022-03-21 21:15:08 +01:00 • committed by GitHub
commit ec7c76d812
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
base/VulkanglTFModel.cpp
View file

@ -1074,7 +1074,7 @@ void vkglTF::Model::loadAnimations(tinygltf::Model &gltfModel)
for (size_t index = 0; index < accessor.count; index++) {
sampler.inputs.push_back(buf[index]);
}
delete[] buf;
for (auto input : sampler.inputs) {
if (input < animation.start) {
animation.start = input;
@ -1100,7 +1100,8 @@ void vkglTF::Model::loadAnimations(tinygltf::Model &gltfModel)
for (size_t index = 0; index < accessor.count; index++) {
sampler.outputsVec4.push_back(glm::vec4(buf[index], 0.0f));
}
break;
delete[] buf;
break;
}
case TINYGLTF_TYPE_VEC4: {
glm::vec4 *buf = new glm::vec4[accessor.count];
@ -1108,7 +1109,8 @@ void vkglTF::Model::loadAnimations(tinygltf::Model &gltfModel)
for (size_t index = 0; index < accessor.count; index++) {
sampler.outputsVec4.push_back(buf[index]);
}
break;
delete[] buf;
break;
}
default: {
std::cout << "unknown type" << std::endl;