Commit graph

1887 commits

Author SHA1 Message Date
Sascha Willems
9041ae3da7
Merge pull request #673 from SaschaWillems/compute_sync
Compute sync
2020-02-22 12:42:59 +01:00
Sascha Willems
780cfee8ab Get compute command buffer via device function 2020-02-22 12:32:17 +01:00
Sascha Willems
acdec3e127 Add proper queue family ownership transfer barriers between compute and graphics (for separate queue families)
Refs #544
2020-02-22 12:20:30 +01:00
Sascha Willems
fff003315b Added overload for passing command pool to cmd buffer create and flush 2020-02-22 11:35:07 +01:00
Sascha Willems
d1fbf8d00a
Skeletalanimation fix (#671)
* Fixed anc code cleanup for skeletal animation

Refs #669

* Fix android build
2020-02-20 14:25:29 +01:00
Sascha Willems
fcb0a2a46a Load UI overla font from asset path
Refs #627
2020-02-17 21:09:43 +01:00
Sascha Willems
662d2b3464 Centralize asset path handling
Refs #470
Refs #627
2020-02-17 21:09:27 +01:00
Sascha Willems
b3d333d1b8
Merge pull request #658 from hhsaez/hernan/fix-assets-paths
Fix asset path for some examples
2020-02-17 20:23:52 +01:00
Sascha Willems
b3749a90ad
Merge pull request #653 from httpdigest/master
Fix typos
2020-02-14 07:00:18 +01:00
Sascha Willems
c4ebdb9c75
Merge pull request #660 from weblucas/patch-1
Fix the cmake_minimum_required for the libktx
2020-02-14 06:57:36 +01:00
Sascha Willems
421baf2ccd
Merge pull request #661 from krOoze/patch-1
Fix README typo
2020-02-14 06:56:36 +01:00
Sascha Willems
e5eb726f59
Merge pull request #664 from gary-sweet/miplevel_clamp
Clamp miplevel size to avoid zero width or height
2020-02-13 18:43:28 +01:00
Sascha Willems
322705c649
Merge pull request #668 from kuhar/discard
Perform sampling before branching to discard to avoid undefined behavior
2020-02-13 18:40:09 +01:00
Jakub Kuderski
8982f8f2ec Perform sampling before branching to discard
This two fragment shaders that exhibit undefined behavior. In GLSL,
it is undefined to use implicit or explicit derivatives in
non-uniform control flow [1]. The SPIR-V produced by glslang contained
similar undefined behavior, which results in incorrect codegen
with the amdvlk's LLPC shader compiler, and produces visually
incorrect image.

This PR fixes this issue by hoisting the sampling so that it's
executed before discarding. It's a simple fix and may not be
the optimial way to resolve this issue.

[1]
https://www.khronos.org/registry/OpenGL/specs/gl/GLSLangSpec.4.60.pdf
p. 137.
2020-02-13 10:01:50 -05:00
Gary Sweet
bdc3b44e7d Clamp miplevel size to avoid zero width or height
I was seeing a zero height in certain circumstances
for textures in scenerendering.
2020-02-07 09:15:13 +00:00
Sascha Willems
3977935d94 Properly resize attachments and update descriptor sets
Refs #414
Refs #659
2020-02-05 20:49:18 +01:00
Sascha Willems
825227a067 Single submission 2020-02-05 19:48:49 +01:00
Sascha Willems
7ef09ae2a8 Use correct image layout for descriptor
Fixes validation
2020-02-05 19:15:37 +01:00
Petr Kraus
1dd3b5a509
Fix README typo 2020-02-05 14:59:14 +01:00
Lucas Teixeira
8dc9f8b173
Fix the cmake_minimum_required for the libktx
I believe that 3.8 was a mistake. I am running 3.5, but all other CmakeFiles have 2.8 as minimum.
2020-01-30 16:52:38 +01:00
Hernan Saez
49bfc20673 Fix asset path for examples 2020-01-25 09:32:48 -03:00
Sascha Willems
fb45d1f741 Divide direction by w-component
Fixes #616
2020-01-24 10:04:31 +01:00
Sascha Willems
db1d12d77f Force minimum window size on Windows
Fixes #579
2020-01-24 09:52:26 +01:00
Sascha Willems
498066749d Removed unused usage flags on depth stencil image 2020-01-24 09:45:48 +01:00
Sascha Willems
ed3d771ce4 Removed unused usage flags on depth stencil image
Fixes #492
2020-01-24 09:39:44 +01:00
Sascha Willems
652fc3ab00 Code cleanup
Fixes #657
2020-01-24 09:16:52 +01:00
Sascha Willems
8acc59a2e1 Code cleanup
Fixes #593
2020-01-18 10:13:14 +01:00
Sascha Willems
e75f2ae739 Merge branch 'master' of https://github.com/SaschaWillems/Vulkan 2020-01-18 10:03:09 +01:00
Sascha Willems
c28adea2f7 Code cleanup
Fixes #643
2020-01-18 10:02:55 +01:00
Sascha Willems
6bc9f95e5d
Merge pull request #652 from NotCamelCase/master
Fix uninitialized variable used in vkCmdCopyBufferToImage().
2020-01-18 09:45:09 +01:00
Sascha Willems
82ba6d8995
Merge pull request #650 from RenfengLiu/fix_validation_error
Fix the validation error for buffer copy
2020-01-18 09:42:04 +01:00
Sascha Willems
4ac729c60b Updated Vulkan headers to 1.2.131 2020-01-18 09:34:46 +01:00
Sascha Willems
339986642f
Merge pull request #634 from hevrard/triangle_present
Be robust to queuePresent returning VK_SUBOPTIMAL_KHR
2020-01-16 20:19:16 +01:00
Sascha Willems
5f83f558ab
Merge pull request #655 from hevrard/fix-build-android-computecloth
Fix Android build of computecloth demo
2020-01-16 20:16:47 +01:00
Hugues Evrard
4e48b38928 Fix Android build of computecloth demo
The NDK compiler currently fails with:

```
examples/computecloth/computecloth.cpp:71:23: error: cannot
initialize a member subobject of type 'VkSemaphore' (aka 'unsigned
long long') with an rvalue of type 'nullptr_t'
                          VkSemaphore ready{ nullptr };
```
2020-01-15 16:29:47 +00:00
httpdigest
5029e15ec6 Fix typos
http://its-not-its.info/
2020-01-12 12:56:16 +01:00
Tayfun Kayhan
2843f4f03b Fix uninitialized variable used in vkCmdCopyBufferToImage(). 2020-01-10 13:28:56 +01:00
Sascha Willems
8668606a14
Merge pull request #651 from chrisforbes/fix-shader-interface-mismatch
Fix interface mismatch between VS and GS in deferredshadows
2020-01-08 19:49:30 +01:00
Chris Forbes
6c4b8727ef Fix interface mismatch between VS and GS in deferredshadows
GLSLang determines the content of the builtin block based on the shading
language version. In the case of 420 vs 450, the difference is whether
the gl_CullDistance member is present.

Vulkan requires that the builtin interface block be the same on both
sides of a shader interface not involving the fragment shader, so this
leads to undefined behavior. This is caught by recent versions of the
validation layers.

Fix the issue by using GLSL 450 for both shaders in the pipeline.
2020-01-07 18:27:13 -08:00
Robin Liu
5a6170e1e9 Fix the validation error for buffer copy 2020-01-07 17:23:50 -05:00
Sascha Willems
7a2dac7e30
Merge pull request #646 from jherico/computecloth
Fix validation and improve sync for computecloth
2020-01-06 20:27:01 +01:00
Sascha Willems
712ae27f87 Remove unused queue create info
Fixes #647
2020-01-06 20:25:02 +01:00
Sascha Willems
e30279fae5 Remove unnecessary assignment
Fixes #648
2020-01-06 20:07:09 +01:00
Brad Davis
e0b557606c Forcing tabs 2020-01-03 09:39:28 -08:00
Brad Davis
19f80fe423 Fix submit wait stages, support same family for graphics & compute 2020-01-03 09:25:24 -08:00
Brad Davis
055d90ea30 Fix validation and improve sync for computecloth 2020-01-02 13:04:03 -08:00
Sascha Willems
e18d428249
Merge pull request #580 from ardrabczyk/typo
Fix typo: Dsiplay->Display
2019-12-21 13:49:13 +01:00
Sascha Willems
bb3b336e53
Merge pull request #637 from SaschaWillems/libktx
Replace gli with libktx
2019-12-08 10:04:25 +01:00
Sascha Willems
af3ae38bd2 ktx loading fixes 2019-12-08 08:58:35 +01:00
Sascha Willems
3537d2cca2 Merge branch 'master' into libktx
# Conflicts:
#	examples/texturemipmapgen/texturemipmapgen.cpp
2019-12-07 16:04:45 +01:00