claude_code/procedural-3d-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
procedural-3d-engine/examples
History
Nathan Gauër fae70ec4ae validation: fix VUID-vkAllocateMemory 02790 
Related to #876.
On AMD RX 5700 XT, heaps with MEMORY_PROPERTY_DEVICE_COHERENT_BIT_AMD
are present. Because the heap selection doesn't break early, the code
ends up selecting one of the 'late' heaps, which contains more property
bits than required. Including this one which causes validation error.

Breaking early should solve this on all GPUs, as the Vulkan specs
specifies the order of heap declarations:
```
For each pair of elements X and Y returned in memoryTypes, X must be
placed at a lower index position than Y if:
    - the set of bit flags returned in the propertyFlags member of X is
      a strict subset of the set of bit flags returned in the
      propertyFlags member of Y;
```

So if my understanding is correct, by breaking early we should always
select the most basic heap that meets the sample needs.

Signed-off-by: Nathan Gauër <nathan@gauer.org>
2023-03-22 23:52:52 +01:00
..
bloom Minor code cleanup 2022-12-09 07:24:32 +01:00
computecloth Merge pull request #925 from galaxysailing/computecloth-update 2022-12-31 13:44:47 +01:00
computecullandlod Fill stats and draw count buffer with zeroes 2022-12-31 16:01:11 +01:00
computeheadless validation: fix VUID-vkAllocateMemory 02790 2023-03-22 23:52:52 +01:00
computenbody Fix queue family transfer operations between graphics <-> compute queues, generalize getQueueFamilyIndex() to support VkQueueFlags vs. VkQueueFlagBits, computecloth deltaT now based on frameTimer 2022-07-07 09:57:01 -04:00
computeparticles Fix queue family transfer operations between graphics <-> compute queues, generalize getQueueFamilyIndex() to support VkQueueFlags vs. VkQueueFlagBits, computecloth deltaT now based on frameTimer 2022-07-07 09:57:01 -04:00
computeraytracing Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
computeshader Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
conditionalrender Simplify push constant setup 2023-02-24 17:03:48 +01:00
conservativeraster Code cleanup 2022-07-30 09:27:50 +02:00
debugmarker Minor code cleanup 2022-12-09 07:24:32 +01:00
deferred Merge pull request #959 from itoral/fix_depth_stencil_aspects 2022-07-30 08:56:32 +02:00
deferredmultisampling Minor code cleanup 2022-12-09 07:24:32 +01:00
deferredshadows Minor code cleanup 2022-12-09 07:24:32 +01:00
descriptorbuffer Use alignment from properties 2022-12-05 20:14:35 +01:00
descriptorindexing Fix cube count & indices logic error in descriptorindexing example 2022-08-08 02:15:03 -04:00
descriptorsets Minor code cleanup 2022-12-09 07:24:32 +01:00
displacement Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
distancefieldfonts Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
dynamicrendering dynamicrendering: use the right layout for depth/stencil 2022-11-21 11:38:44 +02:00
dynamicstate Code cleanup and fixes 2023-02-24 16:13:31 +01:00
dynamicuniformbuffer
gears
geometryshader Minor code cleanup 2022-12-09 07:24:32 +01:00
gltfloading fix: typo in glfwloading example 2022-10-11 10:32:51 +00:00
gltfscenerendering Fixed specialization constant type in readme 2022-12-24 15:31:53 +01:00
gltfskinning Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
graphicspipelinelibrary Change light pos 2022-07-30 09:16:36 +02:00
hdr Merge pull request #959 from itoral/fix_depth_stencil_aspects 2022-07-30 08:56:32 +02:00
imgui Added ImGui style selection 2023-02-25 10:27:47 +01:00
indirectdraw Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
inlineuniformblocks Merge pull request #790 from kuhar/clang-warnings 2022-12-31 14:03:31 +01:00
inputattachments Properly sync depth attachment access 2023-02-11 16:09:05 +01:00
instancing Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
meshshader Minor code cleanup 2022-12-09 07:24:32 +01:00
multisampling Synchronization fix 2023-02-24 16:50:39 +01:00
multithreading Fix F1 on/off toggle for ImGui overlay (all platforms), clean up keycode handling (mostly macOS/iOS) 2022-08-01 16:11:57 -04:00
multiview Merge pull request #959 from itoral/fix_depth_stencil_aspects 2022-07-30 08:56:32 +02:00
negativeviewportheight
occlusionquery Minor code cleanup 2022-12-09 07:24:32 +01:00
offscreen Minor code cleanup 2022-12-09 07:12:45 +01:00
oit MoltenVK-specific fixes for descriptorindexing and oit examples 2022-08-05 00:27:58 -04:00
parallaxmapping
particlefire Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
pbrbasic Minor code cleanup 2022-12-09 07:24:32 +01:00
pbribl fix minor typo 2022-11-15 18:11:05 +02:00
pbrtexture Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
pipelines Fixes to dynamic state behavior in pipelines demo 2022-09-14 15:06:17 +01:00
pipelinestatistics
pushconstants Merge pull request #790 from kuhar/clang-warnings 2022-12-31 14:03:31 +01:00
pushdescriptors Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
radialblur Minor code cleanup 2022-12-09 07:24:32 +01:00
rayquery Removed unused combined sampler from layout 2022-09-26 17:47:59 +02:00
raytracingbasic Reset resize flag after resize is handled 2022-08-11 13:37:06 +02:00
raytracingcallable Reset resize flag after resize is handled 2022-08-11 13:37:06 +02:00
raytracingreflections Remove duplicate code 2022-08-19 17:50:10 +02:00
raytracingsbtdata updating sbt record data example to also cover miss sbt data 2022-09-26 20:28:08 -06:00
raytracingshadows Reset resize flag after resize is handled 2022-08-11 13:37:06 +02:00
renderheadless Replaced outdated android layer names 2022-12-31 10:27:10 +01:00
screenshot
shadowmapping Don't render scene when shadow map is dislplayed 2022-12-31 12:11:21 +01:00
shadowmappingcascade Fix frustum corner calculation for cascading shadows (Vulkan's clip space has a [0,1] z range instead of [-1,1]). 2023-02-20 23:13:19 +01:00
shadowmappingomni Merge pull request #783 from michead/shadowmappingomni 2022-12-31 13:50:18 +01:00
specializationconstants Minor code cleanup 2022-12-09 07:24:32 +01:00
sphericalenvmapping Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
ssao Minor code cleanup 2022-12-09 07:24:32 +01:00
stencilbuffer
subpasses Added sub pass dependency for the depth attachment 2022-12-13 20:49:19 +01:00
terraintessellation Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
tessellation Implement viewChanged() in multiple examples for proper window resize handling, fix triangle example resizing on macOS 2022-07-07 09:57:01 -04:00
textoverlay Fix F1 on/off toggle for ImGui overlay (all platforms), clean up keycode handling (mostly macOS/iOS) 2022-08-01 16:11:57 -04:00
texture Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
texture3d Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
texturearray Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
texturecubemap Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
texturecubemaparray Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
texturemipmapgen Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
texturesparseresidency Removed unnecessary component swizzle assignments 2022-12-31 12:31:27 +01:00
triangle Fix for base subpass depedencies had uninitialized dependency flags. 2023-01-05 13:28:40 +01:00
variablerateshading Fixed specialization constant type 2022-12-24 15:26:48 +01:00
vertexattributes Code Review: a) revert TinyGLTF #defines, b) call vkDeviceWaitIdle() in macOS/iOS termination handlers, c) remove OpenMP target_compile_options() in CMakeLists 2022-07-27 01:21:20 -04:00
viewportarray
vulkanscene
CMakeLists.txt Added sample for VK_EXT_descriptor_buffer 2022-12-04 12:51:14 +01:00