claude_code/procedural-3d-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed parameter names from empty virtual functions (fixes compiler warnings, refs #103)

Browse source
This commit is contained in:
saschawillems 2017-04-22 16:02:39 +02:00
parent bbbb06045e
commit 39824db3e6
3 changed files with 10 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
base/VulkanTextOverlay.hpp
View file

@ -665,7 +665,7 @@ public:
renderPassBeginInfo.clearValueCount = 0; renderPassBeginInfo.clearValueCount = 0;
renderPassBeginInfo.pClearValues = nullptr; renderPassBeginInfo.pClearValues = nullptr;
for (int32_t i = 0; i < cmdBuffers.size(); ++i) for (size_t i = 0; i < cmdBuffers.size(); ++i)
{ {
renderPassBeginInfo.framebuffer = *frameBuffers[i]; renderPassBeginInfo.framebuffer = *frameBuffers[i];

20
base/vulkanexamplebase.cpp
View file

@ -545,10 +545,7 @@ void VulkanExampleBase::updateTextOverlay()
textOverlay->endTextUpdate(); textOverlay->endTextUpdate();
} }
void VulkanExampleBase::getOverlayText(VulkanTextOverlay *textOverlay) void VulkanExampleBase::getOverlayText(VulkanTextOverlay*) {}
{
// Can be overriden in derived class
}
void VulkanExampleBase::prepareFrame() void VulkanExampleBase::prepareFrame()
{ {
@ -1864,20 +1861,11 @@ void VulkanExampleBase::handleEvent(const xcb_generic_event_t *event)
} }
#endif #endif
void VulkanExampleBase::viewChanged() void VulkanExampleBase::viewChanged() {}
{
// Can be overrdiden in derived class
}
void VulkanExampleBase::keyPressed(uint32_t keyCode) void VulkanExampleBase::keyPressed(uint32_t) {}
{
// Can be overriden in derived class
}
void VulkanExampleBase::buildCommandBuffers() void VulkanExampleBase::buildCommandBuffers() {}
{
// Can be overriden in derived class
}
void VulkanExampleBase::createCommandPool() void VulkanExampleBase::createCommandPool()
{ {

11
base/vulkanexamplebase.h
View file

@ -313,8 +313,8 @@ public:
// Containing view dependant matrices // Containing view dependant matrices
virtual void viewChanged(); virtual void viewChanged();
// Called if a key is pressed // Called if a key is pressed
// Can be overriden in derived class to do custom key handling /** @brief (Virtual) Called after a key was pressed, can be used to do custom key handling */
virtual void keyPressed(uint32_t keyCode); virtual void keyPressed(uint32_t);
// Called when the window has been resized // Called when the window has been resized
// Can be overriden in derived class to recreate or rebuild resources attached to the frame buffer / swapchain // Can be overriden in derived class to recreate or rebuild resources attached to the frame buffer / swapchain
virtual void windowResized(); virtual void windowResized();
@ -334,7 +334,7 @@ public:
// Can be overriden in derived class to setup a custom render pass (e.g. for MSAA) // Can be overriden in derived class to setup a custom render pass (e.g. for MSAA)
virtual void setupRenderPass(); virtual void setupRenderPass();
/** @brief (Virtual) called after the physical device features have been read, used to set features to enable on the device */ /** @brief (Virtual) Called after the physical device features have been read, can be used to set features to enable on the device */
virtual void getEnabledFeatures(); virtual void getEnabledFeatures();
// Connect and prepare the swap chain // Connect and prepare the swap chain
@ -371,9 +371,8 @@ public:
void updateTextOverlay(); void updateTextOverlay();
// Called when the text overlay is updating /** @brief (Virtual) Called when the text overlay is updating, can be used to add custom text to the overlay */
// Can be overriden in derived class to add custom text to the overlay virtual void getOverlayText(VulkanTextOverlay*);
virtual void getOverlayText(VulkanTextOverlay * textOverlay);
// Prepare the frame for workload submission // Prepare the frame for workload submission
// - Acquires the next image from the swap chain // - Acquires the next image from the swap chain